search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 27 forks source link

Can we remove this console.log? #55

Closed kameelyan closed 5 years ago

kameelyan commented 5 years ago

https://github.com/KevCJones/ngx-simple-modal/blob/5c91e25da94eb1a3cf74fa280a282d40318eaefe/src/simple-modal/simple-modal-wrapper.component.ts#L65

Can we remove this console.log please?

kevcjones-archived commented 5 years ago

Yeah, if you can make a PR to master, I'll appreciate it. I can do a release later on

On Thu, 8 Aug 2019, 16:20 kameelyan, notifications@github.com wrote:

https://github.com/KevCJones/ngx-simple-modal/blob/5c91e25da94eb1a3cf74fa280a282d40318eaefe/src/simple-modal/simple-modal-wrapper.component.ts#L65

Can we remove this console.log please?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/issues/55?email_source=notifications&email_token=AAFJ54DBKTMQJQ74WNC74P3QDQ2TZA5CNFSM4IKLSZ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HEF44JA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFJ54FNFVTBBLS6QO6IYILQDQ2TZANCNFSM4IKLSZ2Q .

kameelyan commented 5 years ago

https://github.com/KevCJones/ngx-simple-modal/pull/56

kevcjones-archived commented 5 years ago

Ta will bump version today

On Thu, 8 Aug 2019, 23:30 kameelyan, notifications@github.com wrote:

56 https://github.com/KevCJones/ngx-simple-modal/pull/56

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/issues/55?email_source=notifications&email_token=AAFJ54B5YSRYIBA65EMKB7DQDSNADA5CNFSM4IKLSZ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35CQRI#issuecomment-519710789, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFJ54DBSKADILOWIOS5ZEDQDSNADANCNFSM4IKLSZ2Q .

kevcjones-archived commented 5 years ago

Release 1.3.24