search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 27 forks source link

build: use ng-packagr to follow APF specs #61

Closed alan-agius4 closed 5 years ago

alan-agius4 commented 5 years ago

Hi, I am Alan Agius from the Angular Tooling Team. In version 9, Angular will enable Ivy by default, currently this package is not compatible with Ivy because NGCC is unable to run successfully as it doesn't follow the APF (Angular Package Format) spec https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview

With this change we replace the build steps to use ng-packagr so that the distributable can be interpreted by NGCC.

//cc @petebacondarwin, @gkalpak & @mgechev

kevcjones-archived commented 5 years ago

Works nicely, I have a few more checks I'll run but appreciate this. 🙏 Expect a merge and version bump to follow tomorrow morning.