search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 27 forks source link

Fixing issues with #69, @HostListener does not work in modal context #70

Closed yadue closed 4 years ago

kevcjones-archived commented 4 years ago

Thanks for this, will review today and merge if all is well

kevcjones-archived commented 4 years ago

Works nicely in my demo tests 👍

yadue commented 4 years ago

Hey @KevinCJones, thanks for merging, could you push package to npm? Thanks in advance.

kevcjones-archived commented 4 years ago

I thought I did last night, check the latest patch. 👍

On Wed, 1 Apr 2020, 06:44 yadue, notifications@github.com wrote:

Hey @KevinCJones https://github.com/KevinCJones, thanks for merging, could you push package to npm? Thanks in advance.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/pull/70#issuecomment-607046192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJ54FITWC2F4UDUCSIAFLRKLIFRANCNFSM4LWRHXKA .

yadue commented 4 years ago

@KevCJones Sounds like it's not yet there: https://www.npmjs.com/package/ngx-simple-modal?activeTab=versions

kevcjones-archived commented 4 years ago

Intetesting, I'll check when I start work in an hour

On Wed, 1 Apr 2020, 08:25 yadue, notifications@github.com wrote:

@KevCJones https://github.com/KevCJones Sounds like it's not yet there: https://www.npmjs.com/package/ngx-simple-modal?activeTab=versions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/pull/70#issuecomment-607081027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJ54FA45ZF232KXZLLSV3RKLT45ANCNFSM4LWRHXKA .