search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 27 forks source link

wrapperClass does not apply class to simple-modal-wrapper #74

Closed rienheuver closed 3 years ago

rienheuver commented 3 years ago

I want to put a custom class on the <simple-modal-wrapper> in certain cases. More specifically, in some instances I want the backdrop to be entirely transparent. I figured the option wrapperClass would do exactly that, but it puts a class on the dialog-element. So a fix would be to add an option containerClass which can put a class on <simple-modal-wrapper> but in the long run it would make more sense to change that around I think. That'd be a backwards incompatible change though.

https://github.com/Langstra is working on a pull request to implement the first proposal, so to add a containerClass which solves this problem.

rienheuver commented 3 years ago

Nevermind... apparently our implementation was not according to your examples. We basically elevated our styling one level up, so the dialog became the modal-body and the wrapper became the modal/backdrop. Some minor changes to our styling and implementation of this library fixed that though, so we're all good to go now.