[Fix] SCSS animation - Githubissues

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.

MIT License

52 stars 27 forks source link

[Fix] SCSS animation #77

Closed NicolasRoehm closed 2 years ago

NicolasRoehm commented 3 years ago

transform: translate removed
transition: opacity added

kevcjones-archived commented 3 years ago

Thanks for the PR - Quick question : The change itself seems to remove the translation aspect too, any particular reason?

NicolasRoehm commented 3 years ago

As you can see in the Angular 11 demo, the transform: translate transition never works and it was removed from the CSS file. I thought it was an old and residual SCSS property but I can update the styles to make it work with the opacity property if you want ?