search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 27 forks source link

Error when upgrading from angular 15 to angular 16 #84

Open arttu76 opened 1 year ago

arttu76 commented 1 year ago

Got the following error when compiling after upgrading my project from angular 15 to angular 16:

Error: src/app/app.module.ts:430:9 - error NG6002: 'SimpleModalModule' does not appear to be an NgModule class. SimpleModalModule, node_modules/ngx-simple-modal/simple-modal/simple-modal.module.d.ts export declare class SimpleModalModule { This likely means that the library (ngx-simple-modal) which declares SimpleModalModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Edit: migrated to https://material.angular.io/components/dialog/overview - it's okay, but in some parts not as nice as ngx-simple-modal.

looorent commented 1 year ago

The PR #85 fixes this issue. In the meantime, you can test is using package @looorent/ngx-simple-modal.

celsomtrindade commented 1 year ago

@arttu76 @looorent I have also created an alternative for this package, as it's not being mantained anymore. You can find it at this repository.

The main goal is to keep supporting this package and also update it keep in consistency with Angular, such as versions.

horvathpatrik commented 7 months ago

Any news on this issue? Is the package not maintained anymore?