search

kevin-george / lsd_slam

LSD-SLAM
GNU General Public License v3.0
47 stars 38 forks source link

Update ImageDisplay_OpenCV.cpp #21

Open kanishkanarch opened 4 years ago

kanishkanarch commented 4 years ago

I got these two changes because I couldn't see any point cloud in the viewer window. With these changes, viewer is working correctly

kevin-george commented 4 years ago

If this is a problem(having to hit a key everytime), a better solution might be to set the milliseconds to 0 in the calling function?

kanishkanarch commented 4 years ago

If this is a problem(having to hit a key everytime), a better solution might be to set the milliseconds to 0 in the calling function?

I tried it the other way. Rather than changing the millisecond value in the calling function, I changed it inside this called function by doing return cv::waitKey(0);, but it didn't not seem to do anything. The original problem was that without the modification return 1; the viewer window is showing the point cloud viewer camera in red (which it should) but not making any point clouds during any camera maneuver. After this modification, the viewer window is working fine. There is one more major problem with LSD SLAM I've not yet been able to find a solution for. The Depth window blacks out after starting. It doesn't respond at all, but behind the scenes it does work as without the depth code not working, you wouldn't be able to make any point clouds at all in the viewer window.