search

kevin-george / lsd_slam

LSD-SLAM
GNU General Public License v3.0
47 stars 38 forks source link

Creating fix for dynamic reconfigure bug #4

Closed fulkast closed 6 years ago

fulkast commented 6 years ago

In catkin build system the correct command in the python dynamic reconfigure script should be: "from dynamic_reconfigure.parametergeneratorcatkin import *"

fulkast commented 6 years ago

Hi Kevin, May you please give this PR a try on your local system and confirm if it frees us from the necessity of running the 3 copy commands that you currently have in the wiki?

Cheers, Frank

bespoke-code commented 6 years ago

Hello Frank,

Have you tested this on your system? I would gladly try this out tomorrow - I'd be very happy if it simplifies the build process since running extra commands is not always the preffered way to go for me.

I will post my results. I hope for a positive outcome!

All the best, Andrej

fulkast commented 6 years ago

Hello Andrej,

Yes, I did try it. As a matter of fact, I ran $ catkin_make on a clean catkin_ws to make sure that the config headers weren't already previously built by another command.

Still, it would be great if someone else could verify that this also works for them.

Cheers, Frank

bespoke-code commented 6 years ago

Hello Frank,

I can indeed confirm that this addition removes the need of running extra commands as originally presented in the Wiki. Built LSD_SLAM successfully in a clean workspace on Ubuntu 16.04.3 LTS x64 GNOME with only 1 catkin_make command. Awesome! 👍

kevin-george commented 6 years ago

Thank you for the fix @fulkast and thank you for testing that @bespoke-code! I'll update the wiki accordingly :)

Merging fix.