Enhancement: Show _description on popup when choosing a hook config

[xnl-h4ck3r]

Hi Kevin In https://github.com/kevin-mizu/domloggerpp/releases/tag/1.0.5 it says A new _comment root key is available within the configuration JSON (https://github.com/kevin-mizu/domloggerpp/issues/6) (Thanks @xnl-h4ck3r). I assume you meant _description instead of _comment though? It could be useful in the extenion popup to show the _description value below the Hooking selection box, showing the description of the chosen config if it is set. Thanks Xnl

[kevin-mizu]

Hey xnl-h4ck3r

Oops, you're right, I made a mistake with the release. It's now updated. I checked the source code, and it should be working fine with _description (ref).

About adding the _description within the extension popup, I'm wondering if it's a good idea. I'm afraid some users wouldn't want it present as it would take up a lot of space, forcing them to scroll a lot just to access the setting. This would be inconvenient for users who use this key but don't want to see the description. 🤔

In my opinion, it is too specific to be added, as I would need to make it configurable within the settings, making the app a bit more complex for a simple text.

I might be wrong. What do you think about it?

Cheers, Kévin

[xnl-h4ck3r]

Hi @kevin-mizu. Yes, I think you have a point. Most users wouldn't want that. Another thought though, would it be a good idea to also allow _description under each hook, and maybe show that description as a tool tip when you hover over each hook button on the devtools panel, to gove a bit more context if a user wants it? Thanks

[kevin-mizu]

It could be an interesting update! For the moment, I'm focusing on bug fixes and core feature implementation. I'll try to implement this later on.

[xnl-h4ck3r]

Yeah. no rush obviously. Just an idea :) Thanks!