kevin-montrose / Jil

Fast .NET JSON (De)Serializer, Built On Sigil
MIT License
2.15k stars 253 forks source link

Should Version 2.16 Have Been a Major Version? #338

Open Vaccano opened 4 years ago

Vaccano commented 4 years ago

The fix to issue https://github.com/kevin-montrose/Jil/issues/279 causes a conflict when an application uses 2 NuGets that use this library when:

  1. One of the NuGets depends on a pre-change version (2.15.4 for me)
  2. Another that depends on a post change version (2.17 for me)

Basically, the pre-change dependency is looking for a jil.core assembly and cannot find it in the newer version. (See this stack overflow question for details: https://stackoverflow.com/questions/60609571/nuget-package-is-looking-for-exact-version).

I am wondering if that fix (published in 2.16) should have been a major version change? My problem is that the first nuget is automatically upgrading to the later minor versions assuming them to be backwards compatible.

Probably too late to fix now. But I thought I would note that it is causing issues (at least for me).