search

kevin-shannon / connect4

The original vertical four in a line game.
12 stars 3 forks source link

Improvements to the build process #12

Open tannerkrewson opened 6 years ago

tannerkrewson commented 6 years ago

The source files are currently served directly. We could be minifying and packaging them to make the game load faster.

tannerkrewson commented 5 years ago

also @kevers429 wants to use https://prettier.io/

kevin-shannon commented 5 years ago

a9651a2

tannerkrewson commented 5 years ago

It would not be possible to minify the source files using jekyll because Github Pages does not support a jekyll minification plugin (source). We could use something like Travis CI and a custom build script to do it, but I think that would be more complex than it's worth.

However, it could be worth looking into using Cloudflare. Among many things on the list for (free) features, it would minify our source files without a build.

tannerkrewson commented 5 years ago

From 848194b76318c7986faedb37eb09434256446c2f, we now have npm. So, I added prettier 848194b76318c7986faedb37eb09434256446c2f which will automatically run on git commit.

@kevin-shannon You add any style options you want to https://github.com/kevin-shannon/connect4/blob/master/.prettierrc using this guide.