kevin-wayne / algs4

Algorithms, 4th edition textbook code and libraries
http://algs4.cs.princeton.edu/code/
GNU General Public License v3.0
7.42k stars 2.68k forks source link

Fixing: add groupId for maven-source-plugin #49

Closed tochenliqun closed 4 years ago

tochenliqun commented 6 years ago

With groupId missing, the IDE could complain not able to resolve it (happened with me). So just try to add the groupId. -:)

kevin-wayne commented 6 years ago

thanks, updated

On Mar 31, 2018, at 8:28 AM, Liqun Chen notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/kevin-wayne/algs4/pull/49

Commit Summary

• Fixing: add groupId for maven-source-plugin File Changes

• M pom.xml (1) Patch Links:

https://github.com/kevin-wayne/algs4/pull/49.patchhttps://github.com/kevin-wayne/algs4/pull/49.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Kevin Wayne Phillip Y. Goldman '86 Senior Lecturer Department of Computer Science Princeton University

tochenliqun commented 6 years ago

I think the C5 should be C4 since it’s the 5th item. FYI

https://algs4.cs.princeton.edu/34hash/

On Mar 31, 2018, at 8:40 AM, Kevin Wayne notifications@github.com wrote:

thanks, updated

On Mar 31, 2018, at 8:28 AM, Liqun Chen notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/kevin-wayne/algs4/pull/49

Commit Summary

• Fixing: add groupId for maven-source-plugin File Changes

• M pom.xml (1) Patch Links:

https://github.com/kevin-wayne/algs4/pull/49.patchhttps://github.com/kevin-wayne/algs4/pull/49.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Kevin Wayne Phillip Y. Goldman '86 Senior Lecturer Department of Computer Science Princeton University

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevin-wayne/algs4/pull/49#issuecomment-377690348, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdeAAXuplUa7TF7xPTztZSfelNH1wbWks5tj3lJgaJpZM4TCckj.

tochenliqun commented 6 years ago

BTW, seeing a typo at page 471. (Deletion for linear probing). :)

The M should lower case. i = (i + 1 ) % M;

On Apr 8, 2018, at 7:19 AM, Liqun Chen tochenliqun@gmail.com wrote:

I think the C5 should be C4 since it’s the 5th item. FYI

https://algs4.cs.princeton.edu/34hash/ https://algs4.cs.princeton.edu/34hash/

<Screen Shot 2018-04-08 at 7.13.17 AM.png>

On Mar 31, 2018, at 8:40 AM, Kevin Wayne <notifications@github.com mailto:notifications@github.com> wrote:

thanks, updated

On Mar 31, 2018, at 8:28 AM, Liqun Chen <notifications@github.com mailto:notifications@github.com> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/kevin-wayne/algs4/pull/49 https://github.com/kevin-wayne/algs4/pull/49

Commit Summary

• Fixing: add groupId for maven-source-plugin File Changes

• M pom.xml (1) Patch Links:

https://github.com/kevin-wayne/algs4/pull/49.patch https://github.com/kevin-wayne/algs4/pull/49.patchhttps://github.com/kevin-wayne/algs4/pull/49.diff https://github.com/kevin-wayne/algs4/pull/49.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Kevin Wayne Phillip Y. Goldman '86 Senior Lecturer Department of Computer Science Princeton University

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevin-wayne/algs4/pull/49#issuecomment-377690348, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdeAAXuplUa7TF7xPTztZSfelNH1wbWks5tj3lJgaJpZM4TCckj.

kevin-wayne commented 6 years ago

Thanks for the error report (though, it looks like it is fixed in the current printing). In the future, please report book errors using the booksite form

https://algs4.cs.princeton.edu/errata/

and reserve this for errors in algs4.jar.

On Apr 8, 2018, at 8:35 AM, Liqun Chen notifications@github.com wrote:

BTW, seeing a typo at page 471. (Deletion for linear probing). :)

The M should lower case. i = (i + 1 ) % M;

On Apr 8, 2018, at 7:19 AM, Liqun Chen tochenliqun@gmail.com wrote:

I think the C5 should be C4 since it’s the 5th item. FYI

https://algs4.cs.princeton.edu/34hash/ https://algs4.cs.princeton.edu/34hash/

<Screen Shot 2018-04-08 at 7.13.17 AM.png>

On Mar 31, 2018, at 8:40 AM, Kevin Wayne <notifications@github.com mailto:notifications@github.com> wrote:

thanks, updated

On Mar 31, 2018, at 8:28 AM, Liqun Chen <notifications@github.com mailto:notifications@github.com> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/kevin-wayne/algs4/pull/49 https://github.com/kevin-wayne/algs4/pull/49

Commit Summary

• Fixing: add groupId for maven-source-plugin File Changes

• M pom.xml (1) Patch Links:

https://github.com/kevin-wayne/algs4/pull/49.patch https://github.com/kevin-wayne/algs4/pull/49.patchhttps://github.com/kevin-wayne/algs4/pull/49.diff https://github.com/kevin-wayne/algs4/pull/49.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Kevin Wayne Phillip Y. Goldman '86 Senior Lecturer Department of Computer Science Princeton University

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevin-wayne/algs4/pull/49#issuecomment-377690348, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdeAAXuplUa7TF7xPTztZSfelNH1wbWks5tj3lJgaJpZM4TCckj.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Kevin Wayne Phillip Y. Goldman '86 Senior Lecturer Department of Computer Science Princeton University

tochenliqun commented 6 years ago

I almost finished the book :), some other small things I found in the code. FYI.