search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 389 forks source link

Newline at the end of JSON files #429

Closed michellelynne closed 4 years ago

michellelynne commented 5 years ago

Cassettes created as JSON do not have a newline at the end. Right now, I manually add it before commiting.

michellelynne commented 5 years ago

I'd like to take this issue myself, but not sure if it will be valid since it's just style. Thoughts?

colonelpanic8 commented 5 years ago

@michellelynne ending files with a newline is a good idea. e.g. cat doesn't work properly if they don't.

We would happily accept a pull request for this.

neozenith commented 4 years ago

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant?

If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant.

However if it is still needed, please feel free to re-open or create a new ticket.

Thanks! 🙏

AaronRobson commented 4 years ago

I'll pick this up shortly.

AaronRobson commented 4 years ago

Please see PR for a fix and test.

Do the other formats like yaml have the same issue?

AaronRobson commented 4 years ago

@IvanMalison I don't suppose you'd merge the PR for us would you?

neozenith commented 4 years ago

Hi, I just wanted to update active PRs and issues to let you know I will no longer be an active maintainer on this project.

I recently changed jobs where I no longer use VCRpy or Python at all so I don't have the bandwidth anymore. I won't be monitoring issues or PRs either.

I will have to delegate to other maintainers or ask for some contributors to step up.

I know the Azure CLI uses VCRpy so it would be nice if they could spare some sprint time to maintain this project as it was invaluable in our CI when I was using it.

Kind regards, Josh

neozenith commented 4 years ago

@arthurHamon2 this could be a quick win release?