search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

Automatic Naming (with parametrized ?) breaks cloning in windows #630

Closed slamer59 closed 12 months ago

slamer59 commented 2 years ago

In saleor, vcr is used and produced names breaks because windows doesnot accept some characters [, ] :, etc...

https://github.com/saleor/saleor/pull/9086

Do you have a workaround ? Or an idea to improve automatic name generation ?

You can see the results here: https://github.com/saleor/saleor/tree/main/saleor/graphql/core/tests/cassettes

The test : https://github.com/saleor/saleor/blob/237a8cce5fdc88d2995903c4c872344669f6fd08/saleor/graphql/core/tests/test_core.py#L388

hartwork commented 12 months ago

Hi @slamer59,

from that description it is not clear to me what the problem in VCR would be and commit https://github.com/saleor/saleor/commit/f6c268d2ea08f3417dee1a761617e98a6b78b2c7 seems to indicate that it's outside of VCR. If this needs fixing, it will need a minimal reproducible example. I'm adding label "need info" for now since this is blocking to go further.

slamer59 commented 12 months ago

Hello, I understand.

It was 2 years ago now so hard for me to come back on this.

Thanks anyway

hartwork commented 12 months ago

@slamer59 thanks for your reply, I'll close this as obsolete then.