search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

Fix filter_query_parameters for aiohttp #683

Closed salomvary closed 1 year ago

salomvary commented 1 year ago

For some unknown reason, the aiohttp stub was recording the unfiltered request URL as part of the response in the cassette. Other stubs do not seem to do this and I found no other requirement for response.url to be present, therefore the easy fix was to remove it entirely.

Fixes #517.

scop commented 1 year ago

Looks like some conflicts have cropped up here.

hartwork commented 1 year ago

@salomvary I'm only helping out with VCR.py a bit but I can try having a closer look and do review if the conflicts get fixed.

salomvary commented 1 year ago

@salomvary I'm only helping out with VCR.py a bit but I can try having a closer look and do review if the conflicts get fixed.

I'm unlikely to have time for resolving these conflicts in the near future.

hartwork commented 1 year ago

@salomvary thanks for your reply and your ideas on a fix. I'll be closing this one and taking your ideas to a new pull request #740. Closing…