search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

Integrate vcrpy-unittest (alternative to #709) #712

Closed hartwork closed 1 year ago

hartwork commented 1 year ago

Alternative to #709

codecov-commenter commented 1 year ago

Codecov Report

Merging #712 (d613a81) into master (3239911) will increase coverage by 0.61%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   89.78%   90.40%   +0.61%     
==========================================
  Files          27       28       +1     
  Lines        1743     1772      +29     
  Branches      243      313      +70     
==========================================
+ Hits         1565     1602      +37     
+ Misses        143      135       -8     
  Partials       35       35
Impacted Files Coverage Δ
vcr/__init__.py 100.00% <100.00%> (ø)
vcr/config.py 95.06% <100.00%> (ø)
vcr/unittest.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

agriffis commented 1 year ago

one small doc comment, otherwise looks fine to me at a glance. I haven't used this in a number of years, so I won't be testing it.

hartwork commented 1 year ago

@kevin1024 I believe this pull request is ready fro prime time. Any concerns left about merging?