search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

Use python3 (and pip3) command #720

Closed hartwork closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #720 (d2f2731) into master (ffb2f44) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          28       28           
  Lines        1774     1774           
  Branches      313      313           
=======================================
  Hits         1602     1602           
  Misses        137      137           
  Partials       35       35
Impacted Files Coverage Δ
vcr/migration.py 74.48% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jairhenrique commented 1 year ago

python and pip are aliases for python3 and pip3. What was the motivation for this change?

hartwork commented 1 year ago

python and pip are aliases for python3 and pip3. What was the motivation for this change?

@jairhenrique not in all environments, e.g. not for users of Debian bullseye with package python-is-python2 installed. In some sense this pull request is a bit late.

The motivator is comment https://github.com/kevin1024/vcrpy/pull/718#discussion_r1233336313, being more explicit about Python 3 and being waterproof about it.

What do you think?