[5.0.0] No cassettes found? Worked with 4.x.x

Alexander-Serov commented 1 year ago

For some reason, after upgrading to vcrpy==5.0.0, the old cassettes on our working pipeline are not found anymore. Since there are no changes in code, something seems to have changed in vcrpy.

I understand it's a major version release, so it is the right place to introduce new functionality and break the old one, but in this case, I would like to suggest a clearer message to the user on how to fix it. For the moment, it just says that the cassettes are not found, which is wrong. They are present at the same location they are found by v4.*.

------------------------------ Captured log setup ------------------------------
INFO: <function VCR._build_before_record_request.<locals>.before_record_request at 0x7fa1fb8f5670>
_ ERROR at setup of file _
request = <SubRequest 'vcr' for <Function test_>>
vcr_markers = [Mark(name='vcr', args=(), kwargs={})]
vcr_cassette_dir = '/builds//tests/cassettes/test_fitting'
record_mode = 'none', disable_recording = False
pytestconfig = <_pytest.config.Config object at 0x7fa2225b41c0>
    @pytest.fixture(autouse=True)  # type: ignore
    def vcr(  # pylint: disable=too-many-arguments
        request: SubRequest,
        vcr_markers: List[Mark],
        vcr_cassette_dir: str,
        record_mode: str,
        disable_recording: bool,
        pytestconfig: Config,
    ) -> Iterator[Optional[Cassette]]:
        """Install a cassette if a test is marked with `pytest.mark.vcr`."""
        if disable_recording:
            yield None
        elif vcr_markers:
            config = request.getfixturevalue("vcr_config")
            default_cassette = request.getfixturevalue("default_cassette_name")
>           with use_cassette(
                default_cassette, vcr_cassette_dir, record_mode, vcr_markers, config, pytestconfig
            ) as cassette:
venv/lib/python3.8/site-packages/pytest_recording/plugin.py:150: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
venv/lib/python3.8/site-packages/vcr/cassette.py:89: in __enter__
    self.__cassette = self.cls.load(**cassette_kwargs)
venv/lib/python3.8/site-packages/vcr/cassette.py:177: in load
    new_cassette._load()
venv/lib/python3.8/site-packages/vcr/cassette.py:350: in _load
    requests, responses = self._persister.load_cassette(self._path, serializer=self._serializer)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = CombinedPersister(extra_paths=[])
cassette_path = '/builds//tests/cassettes/test_fitting/test_.yaml'
serializer = <module 'vcr.serializers.yamlserializer' from '/builds/venv/lib/python3.8/site-packages/vcr/serializers/yamlserializer.py'>
    def load_cassette(self, cassette_path: str, serializer: ModuleType) -> Tuple[List, List]:
        all_paths = chain.from_iterable(((cassette_path,), self.extra_paths))
        # Pairs of 2 lists per cassettes:
        all_content = (load_cassette(path, serializer) for path in unique(all_paths))
        # Two iterators from all pairs from above: all requests, all responses
        # Notes.
        # 1. It is possible to do it with accumulators, for loops and `extend` calls,
        #    but the functional approach is faster
        # 2. It could be done more efficient, but the `deserialize` implementation should be adjusted as well
        #    But it is a private API, which could be changed.
        requests, responses = starmap(unpack, zip(*all_content))
        requests, responses = list(requests), list(responses)
        if not requests or not responses:
>           raise ValueError("No cassettes found.")
E           ValueError: No cassettes found.
venv/lib/python3.8/site-packages/pytest_recording/_vcr.py:48: ValueError