search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

fix(stubs/httpx): fix decode error on utf-8 response with file #820

Closed kszinhu closed 6 months ago

kszinhu commented 10 months ago

On httpx response should be read with ignore error

@hartwork

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68038d0) 92.32% compared to head (f67eac4) 92.32%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #820 +/- ## ======================================= Coverage 92.32% 92.32% ======================================= Files 27 27 Lines 1811 1811 Branches 338 338 ======================================= Hits 1672 1672 Misses 92 92 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

76tr75b commented 8 months ago

Can we get this merged? It solves the issue when recording file uploads with httpx.

hartwork commented 6 months ago

Closing as "mistaken until proven otherwise" and due to lack of a reply…