search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
62 stars 48 forks source link

JOSS review edits and NIRCam wavelength #474

Closed taylorbell57 closed 2 years ago

taylorbell57 commented 2 years ago

This PR does the following:

Resolves #472, resolves #455

Specifically, this PR:

  1. Updates quickstart figures using current code version so that users don't worry about differences between their results and those on the quickstart docs.
  2. Reduces the number of warnings and adds note about expected warnings in quickstart tutorial.
  3. Carries the centroid_sx from S3 photometry through to S4 (previously was forgotten, so it was unavailable in Stage 5).
  4. Implements the NIRCam longwave wavelength solutions using a polynomial fit computed by Everett Schlawin (@eas342) for F322W2 and F444W. These can be used by setting meta.poly_wavelength=True, otherwise the values in the FITS files will be used. This new meta parameter has been documented in the ECF docs and is assumed to be False if not put in the ECF.
dfm commented 2 years ago

This looks great to me! I can confirm that the updated figures are consistent with those that I got when running the Quickstart locally. 🎉