kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
60 stars 47 forks source link

[Enhancement]: Safer skyin + skyout aperture specification #490

Closed taylorbell57 closed 1 year ago

taylorbell57 commented 1 year ago

Instrument

NIRCam (Stages 1-3), MIRI (Stages 1-3)

What is your suggestion?

As of right now, for photometric background annulus selection is specified using skyin and skyout as the inner and outer radii of the annulus. This leaves open the possibility of a user specifying an inside-out annulus where skyout is smaller than skyin. It also makes it hard to specify a range of skyin and skyout sizes that the code should automatically try as some subset of the skyout array might be interior to some subset of the skyin array.

In my opinion, a better solution would be to specify skyin and skywidth, so to have an annulus spanning 15-25 pixels, you'd specify skyin=15, skywidth=10. That'll easily allow you to try a range of aperture sizes and inner radii without having to have any code to check that skyout is larger than skyin.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct