kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
60 stars 47 forks source link

Add full frame outlier rejection capabilities #502

Closed kevin218 closed 1 year ago

kevin218 commented 1 year ago

Instead of only performing outlier rejection along the time axis within the BG region, this added functionality allows the user to perform outlier rejection on the entire frame. This step (when enabled) takes place before computing the median frame, so has the potential to yield a more reliable median frame. The risk is that, for deep transits, this routine could flag in-transit points as bad. So, this method should be used with caution.

I have updated the demos and test directories, but not the html file.

codecov-commenter commented 1 year ago

Codecov Report

Merging #502 (dd1f090) into main (fc19ced) will increase coverage by 0.04%. The diff coverage is 80.76%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   59.70%   59.75%   +0.04%     
==========================================
  Files          87       87              
  Lines       10119    10137      +18     
==========================================
+ Hits         6042     6057      +15     
- Misses       4077     4080       +3     
Impacted Files Coverage Δ
src/eureka/lib/util.py 79.08% <0.00%> (ø)
src/eureka/S3_data_reduction/miri.py 58.40% <50.00%> (-0.16%) :arrow_down:
src/eureka/S3_data_reduction/nirspec.py 82.25% <50.00%> (-1.62%) :arrow_down:
src/eureka/S3_data_reduction/optspex.py 49.05% <60.00%> (-0.16%) :arrow_down:
src/eureka/S3_data_reduction/nircam.py 73.68% <100.00%> (+1.29%) :arrow_up:
src/eureka/S3_data_reduction/s3_reduce.py 91.47% <100.00%> (+0.16%) :arrow_up:
src/eureka/S6_planet_spectra/s6_spectra.py 50.06% <0.00%> (+0.13%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

taylorbell57 commented 1 year ago

Is this PR ready for my review? I see the pytest is marked as failed, but it looks like it was just a temporary failure to upload the test results and did actually pass, so don't worry about that

kevin218 commented 1 year ago

Yeah, I think now would be a good time to review it.

taylorbell57 commented 1 year ago

Just merging in the now-updated main branch so I can tell what was added in this PR vs your earlier PR