Closed taylorbell57 closed 1 year ago
Merging #504 (e4e57d3) into main (c38bb2c) will decrease coverage by
0.04%
. The diff coverage is43.20%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 59.63% 59.60% -0.04%
==========================================
Files 87 87
Lines 10079 10124 +45
==========================================
+ Hits 6011 6034 +23
- Misses 4068 4090 +22
Impacted Files | Coverage Δ | |
---|---|---|
src/eureka/S3_data_reduction/nircam.py | 72.39% <ø> (ø) |
|
src/eureka/S3_data_reduction/miri.py | 53.14% <32.72%> (-12.90%) |
:arrow_down: |
src/eureka/S3_data_reduction/plots_s3.py | 75.00% <58.33%> (+0.19%) |
:arrow_up: |
src/eureka/S3_data_reduction/s3_reduce.py | 90.03% <66.66%> (-1.27%) |
:arrow_down: |
src/eureka/lib/centerdriver.py | 92.30% <100.00%> (ø) |
|
src/eureka/lib/util.py | 79.08% <100.00%> (ø) |
|
src/eureka/lib/utc_tt.py | 88.52% <0.00%> (+19.67%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Alight, I think I've addressed all your comments (aside from the edits that need to wait for #502 to be merged).
I do, however, want your opinion on whether I should continue using skyin
and skyout
as is currently done or instead use skyin
and skywidth
to make it impossible to have skyout < skyin
and to make it a bit easier to loop over different aperture options (using an n*m grid of skyin
and skywidth
values instead of having to specify one skyout
for each skyin
)
This PR enables the use of Eureka! for MIRI photometry.
In particular, this PR:
This PR also:
I think @sebastian-zieba also had a MIRI photometry branch under development. Depending on how close that is to being ready for a PR, we can either: