codecov-commenter
commented
1 year ago Codecov Report
Merging #507 (7279cf0) into main (7db9d36) will decrease coverage by
0.46%. The diff coverage is20.33%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 59.74% 59.28% -0.46%
==========================================
Files 87 89 +2
Lines 10137 10255 +118
==========================================
+ Hits 6056 6080 +24
- Misses 4081 4175 +94 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/eureka/lib/astropytable.py | 70.00% <11.11%> (-17.10%) |
:arrow_down: |
| src/eureka/S1_detector_processing/bias_sub.py | 12.65% <12.65%> (ø) |
|
| src/eureka/S1_detector_processing/s1_process.py | 14.00% <25.00%> (+0.45%) |
:arrow_up: |
| src/eureka/S1_detector_processing/superbias.py | 46.15% <46.15%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
kevin218
This PR modifies/overrides the JWST pipeline's superbias step (within Stage 1) to apply a scale factor correction. There are numerous options available in the ECF that can be applied, but the general procedure is the same. The code always computes a scale factor (SF) correction as follows: SF = (median of group)/(median of superbias), using a background region that is
meta.expand_maskpixels from the measured trace. Depending onmeta.bias_correction(options include: mean, group_level, smooth, None)and meta.bias_group(options include: 1, 2, ..., each), the code applies various corrections to the superbias before subtracting from the data.