kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
60 stars 47 forks source link

Bug patches after latest PR #511

Closed taylorbell57 closed 1 year ago

taylorbell57 commented 1 year ago

The latest PR unfortunately introduced some glaring bugs which I didn't catch myself nor did the automated tests.

  1. Because of the way I implemented the new meta.nints code, unshared fits would break after fitting for the first lightcurve.
  2. SinusoidalPhaseCurve fits would break with the PyMC3 version of the code as chan was always used but not always defined.
  3. Also, at present, setting waverange_start and waverange_end to None causes a crash for NIRSpec spectra which shouldn't happen. Users should be able to use the default extraction if they want (or need).

Aside from resolving these bugs, I added a bit nicer formatting for the log statements inside straighten.py.

taylorbell57 commented 1 year ago

I've just re-run my Sagan Summer Workshop notebook for the MIRI data, and it seems there's something wrong with the ypos S5 model as well as the ypos parameter is completely unconstrained with the new code. I'll look into this as soon as I can

codecov-commenter commented 1 year ago

Codecov Report

Merging #511 (118dcb8) into main (0e164a5) will increase coverage by 0.01%. The diff coverage is 78.57%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   58.17%   58.18%   +0.01%     
==========================================
  Files          91       91              
  Lines       10887    10892       +5     
==========================================
+ Hits         6333     6337       +4     
- Misses       4554     4555       +1     
Impacted Files Coverage Δ
...itting/differentiable_models/SinusoidPhaseCurve.py 19.25% <0.00%> (-0.29%) :arrow_down:
...S5_lightcurve_fitting/models/SinusoidPhaseCurve.py 83.14% <ø> (+0.92%) :arrow_up:
src/eureka/S2_calibrations/s2_calibrate.py 80.14% <100.00%> (+0.14%) :arrow_up:
src/eureka/S3_data_reduction/straighten.py 100.00% <100.00%> (ø)
src/eureka/S5_lightcurve_fitting/s5_fit.py 68.71% <100.00%> (ø)
src/eureka/lib/split_channels.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

taylorbell57 commented 1 year ago

Alright, well that's all of the known bugs I introduced with the latest PR taken care of!...