kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

Skip masking trace, etc when bias_correction is None; enable row-by-row BG subtraction; edit NIRCam extraction height #524

Closed kevin218 closed 1 year ago

kevin218 commented 1 year ago

This resolves #522 by skipping a bunch of unnecessary steps in bias_sub.py when meta.bias_correction is None.

codecov-commenter commented 1 year ago

Codecov Report

Merging #524 (4f2fb93) into main (0463d10) will decrease coverage by 0.08%. The diff coverage is 31.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   57.59%   57.52%   -0.08%     
==========================================
  Files          92       92              
  Lines       11087    11127      +40     
==========================================
+ Hits         6386     6401      +15     
- Misses       4701     4726      +25     
Impacted Files Coverage Δ
src/eureka/S1_detector_processing/bias_sub.py 12.34% <0.00%> (-0.32%) :arrow_down:
src/eureka/S1_detector_processing/group_level.py 8.42% <0.00%> (-1.11%) :arrow_down:
src/eureka/S1_detector_processing/s1_process.py 13.59% <0.00%> (-0.14%) :arrow_down:
src/eureka/S5_lightcurve_fitting/s5_fit.py 67.71% <0.00%> (-1.01%) :arrow_down:
src/eureka/S5_lightcurve_fitting/fitters.py 64.85% <25.00%> (-0.13%) :arrow_down:
src/eureka/S3_data_reduction/source_pos.py 66.66% <73.33%> (-4.93%) :arrow_down:
src/eureka/S2_calibrations/s2_calibrate.py 79.72% <75.00%> (-0.43%) :arrow_down:
src/eureka/S3_data_reduction/s3_reduce.py 87.84% <91.66%> (+0.30%) :arrow_up:
src/eureka/S3_data_reduction/background.py 42.44% <100.00%> (+2.04%) :arrow_up:
src/eureka/S3_data_reduction/nircam.py 75.13% <100.00%> (+0.27%) :arrow_up:
... and 1 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kevin218 commented 1 year ago

Got it! I had fixed a related problem, but not the exact one you were describing.

kevin218 commented 1 year ago

@taylorbell57 Do you have any other concerns about this PR before we merge?