kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

Corrected issues with mgmc centroiding, cleaned up formatting, and corrected plotting features. #532

Closed isaedelman closed 1 year ago

isaedelman commented 1 year ago

Corrected plotting features, addressed edge cases with the mgmc centroiding method, and cleaned up formatting.


-Added dashed zero lines to fig.3109 to help identify if any slopes occur.

Before:

fig3109-Centroid

after:

fig3109-Centroid

-Reformatted fig.3503 to display and corrected 1D gaussians to source in x and y directions.

Before:

fig3503_file0_int001_Centroid_Fit

After:

fig3503_file0_int000_Centroid_Fit

-Corrected labeling in fig.3507 to display batch values instead of segment values.

-Tweaked s3_reduce.py to remember the first median frame for centroiding method to address issues where a new batch could have a bad start frame for the primary centroid guess causing the position to drift over time.

-Renamed the initial centroiding guess position variable for the mgmc method to address issues with position variable being over written by fgc position.

-Changed font size for fig.5101 to make the side labels not smooshed.

Before:

fig5101_ch0_lc_nuts

After:

fig5101_ch0_lc_nuts

-Updated the mgmc centroiding method to account for the saved median frame used for centroiding position.


This passes test_Photometry_NIRCam.py on my laptop and is flake8 compliant.