search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

[Enhancement]: Use single median frame for all segments #538

Closed kevin218 closed 8 months ago

kevin218 commented 1 year ago

Instrument

NIRSpec (Stages 1-3), NIRCam (Stages 1-3), MIRI (Stages 1-3)

What is your suggestion?

When processing Stage 3 data in batches, a median frame is computed for each batch. This sometimes leads to flux offsets in the light curves between batches. By default, the code should only use the median frame from the first batch. Users should provide an optional argument if they want a median frame computed for each batch.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

taylorbell57 commented 9 months ago

@kevin218 I'm adding this right now. Any preferences on what we call the optional ECF parameter that overrides the new default behaviour and computes a seperate median frame for each batch?

kevin218 commented 9 months ago

@kevin218 I'm adding this right now. Any preferences on what we call the optional ECF parameter that overrides the new default behaviour and computes a seperate median frame for each batch?

Nothing comes to mind at the moment. Feel free to suggest something here.

taylorbell57 commented 9 months ago

What about meta.indep_batches or something like that, set to False by default?

Edit: I changed independent_batches to indep_batches to keep the ECF line and code shorter