search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

Edit DL script to put HST files in same directory. #543

Closed jbrande closed 1 year ago

jbrande commented 1 year ago

Edited the demo HST MAST download script to remove the call to sortHST() that splits up the direct images and spectra into different directories. Also edited the S3 ECF docs page to remove text that implies these should be split up into sci and cal directories, and clarified they should be in the same directory. This should remove any confusion by new HST users (and me, after several weeks of not thinking about HST).

Should we also remove sortHST() as a function? Probably not, right?

codecov-commenter commented 1 year ago

Codecov Report

Merging #543 (b5dfef4) into main (8b85d76) will decrease coverage by 0.04%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   57.72%   57.69%   -0.04%     
==========================================
  Files          92       92              
  Lines       11135    11135              
==========================================
- Hits         6428     6424       -4     
- Misses       4707     4711       +4

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jbrande commented 1 year ago

The merge conflict was easy to fix but the supposed pytest failure is actually something weird in codecov that's failing after the tests run. No clue what it is.