kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

HST ramp model and enabling calibrated spectra - v2 #544

Closed kevin218 closed 1 year ago

kevin218 commented 1 year ago

This PR is in response to requested changes to #534. I'm not sure why my push created a new PR, but here we are. Once this gets approved, I'll delete the other PR.

codecov-commenter commented 1 year ago

Codecov Report

Merging #544 (5c6909e) into main (5c585fb) will decrease coverage by 0.69%. The diff coverage is 2.87%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   57.68%   57.00%   -0.69%     
==========================================
  Files          92       94       +2     
  Lines       11145    11282     +137     
==========================================
+ Hits         6429     6431       +2     
- Misses       4716     4851     +135     
Impacted Files Coverage Δ
...urve_fitting/differentiable_models/HSTRampModel.py 0.00% <0.00%> (ø)
...ureka/S5_lightcurve_fitting/models/HSTRampModel.py 0.00% <0.00%> (ø)
src/eureka/S3_data_reduction/s3_reduce.py 88.09% <16.66%> (-1.49%) :arrow_down:
src/eureka/S5_lightcurve_fitting/s5_fit.py 66.35% <37.50%> (-0.72%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kevin218 commented 1 year ago

@taylorbell57 In case you didn't get notified, I addressed the remaining two comments.

taylorbell57 commented 1 year ago

Thanks @kevin218, for some reason this time I did get emails about your commits, but better safe than sorry. I'm completely occupied with OWL this week, but this is on my to-do list for next week