Fixing buggy masking of entire wavelength LCs

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.

https://eurekadocs.readthedocs.io/

MIT License

58 stars 45 forks source link

Fixing buggy masking of entire wavelength LCs #549

Closed taylorbell57 closed 11 months ago

taylorbell57 commented 1 year ago

Resolves #547

Because the apmask wasn't applied when computing the stdspec, any wavelength that ever had a masked pixel within the source aperture would end up having it's entire lightcurve be masked. This PR applies the mask to the apdata-like arrays and throws in some extra np.ma calls in optspex for good measure.

taylorbell57 commented 1 year ago

Alright, running the tests locally now, but I think this one should be ready for you now @kevin218

taylorbell57 commented 1 year ago

Confirmed that all tests pass locallly

taylorbell57 commented 12 months ago

The tests all pass locally now FYI