search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

Updated install instructions to fix deprecation #551

Closed taylorbell57 closed 1 year ago

taylorbell57 commented 1 year ago

The current pip installation method using egg= raises a warning about a deprecation that is coming with pip version 25.0. To get ahead of that, let's change things now.

The warning that is currently raised is:

DEPRECATION: git+https://github.com/kevin218/Eureka.git@dev/tjb#egg=eureka[jwst] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce this behaviour change. A possible replacement is to use the req @ url syntax, and remove the egg fragment. Discussion can be found at https://github.com/pypa/pip/issues/11617

taylorbell57 commented 1 year ago

@kevin218, can we aim to merge this tiny PR before the Sagan Summer Workshop so that we don't end up with any headaches if the new pip version gets released between now and then

kevin218 commented 1 year ago

I don't know what's going on with pytest

taylorbell57 commented 1 year ago

Me neither, and I can't do a thorough test because apparently my miniconda installation is broken somehow (can't make new environments). I'm running a local test right now, but I know that this installation method works from the Colab notebooks

taylorbell57 commented 1 year ago

Tests run fine locally on my pre-existing conda environment, and I know this installation method works fine from the Google Colab installations I've been doing, so I'm just going to merge this now