search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
58 stars 45 forks source link

Restrict ap_y1 and ap_y2 to values within subarray #564

Closed jbrande closed 11 months ago

jbrande commented 1 year ago

This might resolve #561, where certain spec_hw values sometimes run off the edge of the subarray and break things. ap_y1 can now no longer be less than 0 and ap_y2 can now no longer be longer than the subarray in question. I haven't exhaustively tested it, but what I have done seems to handle both failure modes. I don't think this ruins later bits of S3, and my initial runs seem to behave okay, but I'd like some other eyes on this.

jbrande commented 11 months ago

Weird, pytests finished fine on my machine but still fail here.

taylorbell57 commented 11 months ago

Weird, pytests finished fine on my machine but still fail here.

Yeah, it's not your issue - GitHub has been having issues with all PRs for the past month or so. I haven't been able to figure out what the issue is despite spending an hour or two trying to troubleshoot it