search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
60 stars 47 forks source link

Calibrated MIRI spectra #585

Closed kevin218 closed 10 months ago

kevin218 commented 10 months ago

Generating calibrated MIRI spectra was super easy... just a few lines.

taylorbell57 commented 10 months ago

Gah, but for some reason the pytest failed which really can't be related to your changes... Let me see what I can do - probably just need to set an upper limit or something

taylorbell57 commented 10 months ago

Looks to me like it is just that your flexo branch is based on an old version of the main branch, and I think merging in the updates from main should let the tests pass without any new edits to the requirements

codecov-commenter commented 10 months ago

Codecov Report

Attention: 326 lines in your changes are missing coverage. Please review.

Comparison is base (559f703) 57.02% compared to head (b783b44) 57.60%. Report is 148 commits behind head on main.

Files Patch % Lines
src/eureka/S5_lightcurve_fitting/models/GPModel.py 5.00% 152 Missing :warning:
src/eureka/S5_lightcurve_fitting/s5_fit.py 30.30% 23 Missing :warning:
src/eureka/S3_data_reduction/nirspec.py 28.00% 18 Missing :warning:
src/eureka/S3_data_reduction/niriss_python.py 11.76% 15 Missing :warning:
src/eureka/S5_lightcurve_fitting/plots_s5.py 71.15% 15 Missing :warning:
src/eureka/S5_lightcurve_fitting/likelihood.py 54.83% 14 Missing :warning:
src/eureka/S3_data_reduction/miri.py 57.14% 9 Missing :warning:
src/eureka/S3_data_reduction/s3_reduce.py 80.43% 9 Missing :warning:
src/eureka/S3_data_reduction/nircam.py 61.90% 8 Missing :warning:
...curve_fitting/differentiable_models/PyMC3Models.py 71.42% 8 Missing :warning:
... and 18 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #585 +/- ## ========================================== + Coverage 57.02% 57.60% +0.58% ========================================== Files 94 96 +2 Lines 11282 11553 +271 ========================================== + Hits 6433 6655 +222 - Misses 4849 4898 +49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.