kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 44 forks source link

Accounting for light travel time in starry model #587

Closed taylorbell57 closed 7 months ago

taylorbell57 commented 7 months ago

So Eric Agol pointed out to Mark Hammond who pointed out to me that by default starry doesn't account for light travel time. Back before version 1.0 I knew starryhad accounted for this but I didn't check the newer version, and apparently with v>=1.0 it doesn't by default. This tiny little PR flips that switch within starry to account for light travel time

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7c6728a) 57.61% compared to head (fc9c444) 57.60%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #587 +/- ## ========================================== - Coverage 57.61% 57.60% -0.01% ========================================== Files 96 96 Lines 11553 11553 ========================================== - Hits 6656 6655 -1 - Misses 4897 4898 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.