Closed taylorbell57 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7c6728a
) 57.61% compared to head (fc9c444
) 57.60%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So Eric Agol pointed out to Mark Hammond who pointed out to me that by default
starry
doesn't account for light travel time. Back before version 1.0 I knewstarry
had accounted for this but I didn't check the newer version, and apparently with v>=1.0 it doesn't by default. This tiny little PR flips that switch withinstarry
to account for light travel time