search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 44 forks source link

Addresses Errors in Stage 5 using LD coefficients from a file #589

Closed kevin218 closed 7 months ago

kevin218 commented 7 months ago

This PR primarily address Issue #588, where using a fixed LD file causes an error in BatmanModels.py. The fix was simple enough and appears to work under the small number of tests that I ran.

I'm also including an assortment of minor improvements in this PR. The most consequential of these changes is enabling the user to manually specify the source position in the ECF.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d148f9b) 57.60% compared to head (006a104) 57.57%. Report is 17 commits behind head on main.

Files Patch % Lines
src/eureka/S3_data_reduction/source_pos.py 16.66% 5 Missing :warning:
src/eureka/S3_data_reduction/s3_reduce.py 40.00% 3 Missing :warning:
src/eureka/S5_lightcurve_fitting/s5_fit.py 0.00% 2 Missing :warning:
src/eureka/S4_generate_lightcurves/s4_genLC.py 0.00% 1 Missing :warning:
...ureka/S5_lightcurve_fitting/models/BatmanModels.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #589 +/- ## ========================================== - Coverage 57.60% 57.57% -0.04% ========================================== Files 96 96 Lines 11553 11566 +13 ========================================== + Hits 6655 6659 +4 - Misses 4898 4907 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kevin218 commented 7 months ago

@taylorbell57 Several people need this fix asap because they are working towards an impending deadline. It would be good to get this merged today. Thanks!