codecov-commenter
commented
9 months ago Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.
Comparison is base (
fb35718) 57.65% compared to head (7d1fa1a) 57.72%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #600 +/- ## ========================================== + Coverage 57.65% 57.72% +0.06% ========================================== Files 96 96 Lines 11629 11643 +14 ========================================== + Hits 6705 6721 +16 + Misses 4924 4922 -2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
kevin218
taylorbell57
This PR implements a few, unrelated enhancements based on my needs while working on several projects over the past week. Fitting LCs to HST WFC3 data is now less sensitive to HST's period because, by adding h6, the reset now happens during Earth occultation instead of at the time of the first science frame. This PR also solves an issue reported in #570 in a slightly different manner than @taylorbell57's solution because I wanted to get the half-pixel edges correct (bounds for detector pixels 5-28 need to be 4.5-28.5). Here's a brief list of fixes:
plots_s3.get_bounds()to correctly define xlim and ylim while accounting for instrument and half-pixels offsets