codecov-commenter
commented
5 months ago Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.
Comparison is base (
fb35718) 57.65% compared to head (8131528) 57.66%.
| Files | Patch % | Lines |
|---|---|---|
| ...ureka/S5_lightcurve_fitting/models/BatmanModels.py | 54.16% | 11 Missing :warning: |
| src/eureka/S6_planet_spectra/s6_spectra.py | 85.71% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #604 +/- ## ======================================= Coverage 57.65% 57.66% ======================================= Files 96 96 Lines 11629 11644 +15 ======================================= + Hits 6705 6714 +9 - Misses 4924 4930 +6 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR resolves #602 by removing the log which cannot be pickled for multiprocessing. The log wasn't really needed anyway, so this was an easy fix.
This PR also fixes a small nuance in how the S6 final spectra are computed since we were previously using sigmas but should be using percentiles which are more robust to non-Gaussian posteriors. I also slightly tweaked how some parameters were loaded in S6 which will become more important as we add more and more fitted parameters (the old code could sometimes get confused in some edge cases).
Finally, this PR allows users to choose whether or not to apply the light travel time correction. This allows backwards compatibilty with old code while also permitting more user freedom. This new S5 ECF parameter has been noted in the docs and has defaults baked into the code.