search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 43 forks source link

Enable modeling of starspots with both Fleck and Starry #627

Open erinmmay opened 4 months ago

erinmmay commented 4 months ago

Exactly what the title says - Adds fleck for starspot modeling, modifies starry code to allow starspots (not recommended, very slow...). Adds a plot to show starspots for fleck. This addresses #605

taylorbell57 commented 4 months ago

@erinmmay, once this PR is ready for review, please mark it as such near the bottom of the page and request a review from Kevin and/or I.

erinmmay commented 2 months ago

Resolved conflicts and set fleck's "fast" option as the default (assumes stellar rotation is much longer than transit time and spots are stationary. user still has option to supply stellar rotation and calculate in "slow" mode). Pulling down the new version of the branch with conflicts resolved to test and then will remove "draft" status so it can be reviewed

erinmmay commented 1 month ago

I'm removing the draft status from this to expedite the process so it can be reviewed now, but I still have a couple tests to run (e.g. making sure this works with dynesty) before it should be merged

erinmmay commented 1 month ago

addressed comments and updated FleckModel.py to use new PlanetParams class. Fully tested with emcee and dynesty.

erinmmay commented 1 month ago

re: adding fleck to tests/NIR*_ecfs/ - it is too slow in my opinion to be a test model.