[Bug]: Setting CorrectDrift to False causes wfc.py in Stage 4 to crash

astroRez commented 6 months ago

FAQ check

[X] Yes, I checked the FAQ and my question has not been addressed.

Instrument

Other (any stage)

What happened?

Because lc.driftmask isn't created when correctDrift is set to False, an error is raised stating lc.driftmask doesnt exist. To resolve this, please change line 82 in wfc3.py of Stage 4 from:

lc.driftmask['time'] = time

to

if meta.correctDrift: 
    lc.driftmask['time'] = time

Which seems to resolve the issue.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

taylorbell57 commented 4 months ago

@kevin218, I see you already made a commit that resolves this in some branch (I can't tell which) - did you want to make a PR with that commit?

kevin218 commented 4 months ago

It was merged with #641. We can close this issue.

kevin218 / Eureka