codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 67.21311% with 20 lines in your changes are missing coverage. Please review.
Project coverage is 54.01%. Comparing base (
4e12d23) to head (f7389d8).
| Files | Patch % | Lines |
|---|---|---|
| src/eureka/S3_data_reduction/plots_s3.py | 52.50% | 19 Missing :warning: |
| src/eureka/S3_data_reduction/s3_reduce.py | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #644 +/- ## ========================================== - Coverage 58.49% 54.01% -4.49% ========================================== Files 101 101 Lines 12646 12692 +46 ========================================== - Hits 7397 6855 -542 - Misses 5249 5837 +588 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request adds in hexagonal apertures to the NIRCam photometry modes, since the defocused image is hexagonal (like the observatory main mirror), and not circular. Thanks to Ian for hacking on this in five minutes and coming up with something twice as fast as what I'd come up with.
This ended up being easy, just a drop-in replacement for the disk routine, and an added ECF parameter
aperture_shapeto control whether we're using circles or hexagons. This seems like it works as-is, but I haven't exhaustively tested it yet. I've also generalized the plotting code slightly to take advantage of this, and it looks like we get proper apertures in plot 3306 now.