search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 43 forks source link

Addressing #649 #650

Open jbrande opened 1 month ago

jbrande commented 1 month ago

Holding off on merging this until I can test more thoroughly, but this should allow for WFC3 exposures of inconsistent read lengths to be properly handled.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.29%. Comparing base (de5b373) to head (5fa38ca). Report is 6 commits behind head on main.

Files Patch % Lines
src/eureka/S3_data_reduction/wfc3.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ========================================== - Coverage 54.29% 54.29% -0.01% ========================================== Files 101 101 Lines 12714 12716 +2 ========================================== + Hits 6903 6904 +1 - Misses 5811 5812 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbrande commented 1 month ago

@taylorbell57, maybe there's a more intelligent place for this check earlier in the step, but this is the first failure point as a result.

taylorbell57 commented 1 month ago

@jbrande, can you remind me what the status of this PR is? I think the recommendation I gave during the team meeting was to pad arrays with NaN values so that you don't have to deal with ragged arrays since I think that was causing an issue for you later on in the code; have you tried that?