search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 43 forks source link

Bug Patch: S6 with similar variable names and S3 undefined aperture_shape #652

Closed taylorbell57 closed 1 month ago

taylorbell57 commented 1 month ago

This little PR resolves the issue where Stage 6 plots malfunctioned for the case where some variables were getting confused by the S6 code. Additionally, I added a small patch to make sure that the default meta.aperture_shape was applied early enough in the code

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 54.30%. Comparing base (de5b373) to head (44bc9ea).

Files Patch % Lines
src/eureka/S6_planet_spectra/s6_spectra.py 20.00% 16 Missing :warning:
src/eureka/S3_data_reduction/s3_reduce.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #652 +/- ## ======================================= Coverage 54.29% 54.30% ======================================= Files 101 101 Lines 12714 12716 +2 ======================================= + Hits 6903 6905 +2 Misses 5811 5811 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.