search

kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
60 stars 47 forks source link

Enables custom bad pixel masks (S1), user supplied wavelength files (S4), adds joint white light curve fitting parameters to docs (S5) #654

Closed erinmmay closed 1 month ago

erinmmay commented 4 months ago

Addressed #638 and also enables users to supply a wavelength file in S4 for pre-computed bins. Also adds joint white light curve fitting to docs and demo ecf to address #530

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.91%. Comparing base (c862d8d) to head (697b066). Report is 13 commits behind head on main.

Files Patch % Lines
src/eureka/S1_detector_processing/s1_meta.py 0.00% 2 Missing :warning:
src/eureka/S1_detector_processing/s1_process.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #654 +/- ## ======================================= Coverage 58.90% 58.91% ======================================= Files 111 111 Lines 13430 13430 ======================================= + Hits 7911 7912 +1 + Misses 5519 5518 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

taylorbell57 commented 1 month ago

@kevin218, do you want to take a look at this PR too since I made a bunch of edits (and therefore am at least somewhat conflicted), or should I just merge this in now?

kevin218 commented 1 month ago

@taylorbell57 yeah, I should probably take a look at your edits before merging. I can do that tomorrow.