kevin218 / Eureka

Eureka! is a data reduction and analysis pipeline intended for time-series observations with JWST.
https://eurekadocs.readthedocs.io/
MIT License
56 stars 43 forks source link

[Enhancement]: Add phase curve amplitude and offset calculations to Stage 6 #655

Open kevin218 opened 1 month ago

kevin218 commented 1 month ago

Instrument

Light curve fitting (Stages 4-6)

What is your suggestion?

The current settings (e.g., pc_offset and pc_amp) calculate the phase curve offset and amplitude of the individual orders, not the combined phase curve. We should add functionality for computing the actual offset, amplitude, and A_obs. We should also clarify some of the language/parameters names so as to avoid confusion in ReadTheDocs.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct