Open taylorbell57 opened 3 weeks ago
Attention: Patch coverage is 38.50267%
with 345 lines
in your changes missing coverage. Please review.
Project coverage is 54.01%. Comparing base (
a939236
) to head (caf5823
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Alright, this PR is now known to work well through to Stage 5, but I haven't yet tested to see what impact this has on Stage 6. My suspicion is that Stage 6 will merge together the spectra of all planets, so I'll likely need to address that
This PR reformats the fitted variable names in Stage 5 to use _ch# for different channels and _pl# for different planets. This will make the code far more robust since we can far more easily identify the channel and planet number, and this should also help with Stage 6 bugs. It will also make the variable names a bit more human readable, and this PR should also fix multiple bugs related to trying to manually set different priors or fixed values for different channels.
These changes resolve #643
While I was at it, I also added support for ecosw and esinw in astrophysical models which avoids the well known ecc>0 bias of fitting for ecc and w directly.
I still need to fully integrate and test the _pl tags, especially for starry, and I still need to do a bunch of testing. For now I'm just opening a draft PR to help me keep track of my progress, so don't worry about reviewing it until I mark it as ready for review.
Note, this change is going to break backwards compatibility for S6 running on old S5 outputs, but that isn't a huge deal since S6 isn't critical and we're working towards v1.0