Open kevin36524 opened 11 years ago
timothy1ee
commented
11 years ago Looks good! Delegation or adding targets are both acceptable solutions. If you're adding targets for many events, it's not common to specify them in Interface Builder. The reason is that it's hard to inspect the logic later, as opposed to reading it in code.
You're right, we just used some naive conversion for the numbers, we could get more sophisticated with the form validation.
kevin36524
commented
11 years ago Sir, Thanks for the review. I will take care to use delegations in my future assignments. /cc @timothy1ee -Kevin
On Thu, Aug 1, 2013 at 2:29 PM, Timothy Lee notifications@github.comwrote:
Looks good! Delegation or adding targets are both acceptable solutions. If you're adding targets for many events, it's not common to specify them in Interface Builder. The reason is that it's hard to inspect the logic later, as opposed to reading it in code.
You're right, we just used some naive conversion for the numbers, we could get more sophisticated with the form validation.
— Reply to this email directly or view it on GitHubhttps://github.com/kevin36524/tempConv/issues/1#issuecomment-21923419 .
My app is a complete, please review.
1) Also, I have a question about delegates, I have not used explicit delegation, instead i am directly adding IBAction is that the right way to do it
2) Also to dismiss the keyboard I have added a tochgesture recognizer. Kinda copied from your code ;) Hope it is fine??
3) One glitch that i realize that I am allowing people to enter "10.22.33.111" Although it gets converted fine but display is not being changed.
? /cc @nesquena @timothy1ee