kevin931 / PyCytoData

A Python pipeline for CyTOF data analyses
MIT License
0 stars 0 forks source link

[BUG] No error or warning while loading multiple datasets with mismatched columns #7

Closed kevin931 closed 1 year ago

kevin931 commented 1 year ago

What issues are you experiencing?

When trying to use PyCytoData.FileIO.load_expression() to read a list of files with mismatched or different channel names, there is a bug that stems from the PyCytoData.FileIO.load_delim() method. There are a number of issues:

This occurs only when the number of channels is the same for each file, but further testing is needed.

To Reproduce

We need two files with the same number of channels in each. We can run the following to reproduce the issue:

files: list = ["<file_1>", "<file_2>"]

df = PyCytoData.FileIO.load_expression(files, delim = ",", col_names=True)
df.channels

Expected behavior

At least we should have a warning, but I think an error should be thrown because the current behavior is wrong. Although this technically can be a breaking change, I think we should fix this as a patch as otherwise we can unknowingly cause issues.

Your environment:

kevin931 commented 1 year ago

This issue has been addressed in #13. I will close this once a new release is available.