When trying to use PyCytoData.FileIO.load_expression() to read a list of files with mismatched or different channel names, there is a bug that stems from the PyCytoData.FileIO.load_delim() method. There are a number of issues:
This error is currently undetected: namely, no error or warning is thrown.
The channels will be mismatched (in the order given by each file).
The channel names will be recorded as the channel names of the first file.
This occurs only when the number of channels is the same for each file, but further testing is needed.
To Reproduce
We need two files with the same number of channels in each. We can run the following to reproduce the issue:
At least we should have a warning, but I think an error should be thrown because the current behavior is wrong. Although this technically can be a breaking change, I think we should fix this as a patch as otherwise we can unknowingly cause issues.
What issues are you experiencing?
When trying to use
PyCytoData.FileIO.load_expression()
to read a list of files with mismatched or different channel names, there is a bug that stems from thePyCytoData.FileIO.load_delim()
method. There are a number of issues:This occurs only when the number of channels is the same for each file, but further testing is needed.
To Reproduce
We need two files with the same number of channels in each. We can run the following to reproduce the issue:
Expected behavior
At least we should have a warning, but I think an error should be thrown because the current behavior is wrong. Although this technically can be a breaking change, I think we should fix this as a patch as otherwise we can unknowingly cause issues.
Your environment: