kevinGodell / mp4frag

Parser that works with ffmpeg to read piped data and fragment mp4 into an initialization segment and media segments. It can also get the codec info and generate an fmp4 HLS m3u8 playlist.
https://kevingodell.github.io/mp4frag/
MIT License
68 stars 15 forks source link

Support parsing hevc codec in MOOV atoms #17

Closed lightingbro46 closed 2 years ago

lightingbro46 commented 2 years ago

Because mp4/fmp4 container support HEVC/H.265 codec and I need mp4frag to be able to parse fmp4 segment with HEVC codec for my project , I add a parser to handle this case. I also add a testcase "test13.js" to test that.

kevinGodell commented 2 years ago

Thank you for the pull request. I have been reviewing the code and there are a few things we need to fix. Firstly, can you make your request against the newly created h.265 branch? Also, please see the test I have been playing with to verify the correct codec strings. It requires ffmpeg to generate video and bento4/mp4info to parse and verify the codec string.

lightingbro46 commented 2 years ago

Thank you for your feedback. I will follow your instruction to make new pull request against the newly created h.265 branch, and try to use the test to verify codec string that my code parse.

kevinGodell commented 2 years ago

@lightingbro46 Any progress on that? I am looking forward to your next pull request. You can add the feature to the h.265 branch and I will do the cleanup on the code and try to get it into the next release.