kevinGodell / mp4frag

Parser that works with ffmpeg to read piped data and fragment mp4 into an initialization segment and media segments. It can also get the codec info and generate an fmp4 HLS m3u8 playlist.
https://kevingodell.github.io/mp4frag/
MIT License
69 stars 15 forks source link

Added fix for segment duration calculations with TRUN samples involvi… #18

Closed MathumathiSundaram closed 2 years ago

MathumathiSundaram commented 2 years ago

Added fix for segment duration calculations with TRUN samples involving TRUN and TFHD flags

kevinGodell commented 2 years ago

HI. Thanks for the pull request. Can you please make it against the "duration" branch? Also, can you please provide a video sample or ffmpeg params to generate a video that was not having its duration read correctly?

MathumathiSundaram commented 2 years ago

Hi Kevin,

The forked repository does not list duration branch.

[image: image.png]

Thanks and regards, Mathumathi.

On Mon, Nov 29, 2021 at 6:55 PM Kevin Godell @.***> wrote:

HI. Thanks for the pull request. Can you please make it against the "duration" branch? Also, can you please provide a video sample or ffmpeg params to generate a video that was not having its duration read correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinGodell/mp4frag/pull/18#issuecomment-981632544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWWLXSGUZ6A7FHPL7RCJQS3UON5MLANCNFSM5I6OPIVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kevinGodell commented 2 years ago

i think you would have to run, git fetch, then git checkout duration

kevinGodell commented 2 years ago

code was moved to other pull request https://github.com/kevinGodell/mp4frag/pull/23